Skip to content

Conversation

@maria-robobug
Copy link
Contributor

@maria-robobug maria-robobug commented Oct 2, 2025

Fix #3185.

  • Adds MPTokenAuthorize JSON example and Mainnet transaction.
  • Updates other MPT transactions to use the Mainnet example.

@maria-robobug maria-robobug linked an issue Oct 2, 2025 that may be closed by this pull request
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange to show some of the required common fields (like Fee) but not others (like Sequence) even though both are auto-fillable. The other transaction references are somewhat inconsistent about how much they provide of common and auto-fillable fields, so that's also something we should try to improve. IMO we should provide everything except the fields added in signing (so include Fee, Sequence, and Flags but omit SigningPubKey and TxnSignature).

Also, ideally, we would add a {% tx-example txid="(hash)" /%} tag for the new transaction, with an example from Mainnet (since it'll never be reset, so any full-history server will be able to find it forever).

It might be easier to submit such a transaction yourself rather than trawl the ledger looking for one. I did write a quick script to find and display transactions of types we don't have examples of, but it hasn't found any MPTokenAuthorize examples... yet.

@maria-robobug maria-robobug force-pushed the mptoken-authorize-transaction-sample branch from 20c1f62 to 20225b5 Compare October 16, 2025 10:36
@maria-robobug
Copy link
Contributor Author

maria-robobug commented Oct 16, 2025

It might be easier to submit such a transaction yourself rather than trawl the ledger looking for one. I did write a quick script to find and display transactions of types we don't have examples of, but it hasn't found any MPTokenAuthorize examples... yet.

Yeah couldn't find any so I've now created my own MPT issuance and an MPT holder on Mainnet. I've also updated the other MPT transactions and added the {% tx-example txid="(hash)" /%} tag for each of them.

@maria-robobug maria-robobug force-pushed the mptoken-authorize-transaction-sample branch 2 times, most recently from 08fab4b to 3cf5dd1 Compare October 16, 2025 11:00
@maria-robobug maria-robobug force-pushed the mptoken-authorize-transaction-sample branch from 3cf5dd1 to f511a23 Compare October 16, 2025 11:08
@maria-robobug maria-robobug requested a review from mDuo13 October 16, 2025 15:46
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@maria-robobug maria-robobug merged commit c83fc47 into master Oct 17, 2025
4 of 5 checks passed
@maria-robobug maria-robobug deleted the mptoken-authorize-transaction-sample branch October 17, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update MPTokenAuthorize page to include transaction sample

3 participants