-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add example JSON for MPTokenAuthorize transaction #3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems strange to show some of the required common fields (like Fee) but not others (like Sequence) even though both are auto-fillable. The other transaction references are somewhat inconsistent about how much they provide of common and auto-fillable fields, so that's also something we should try to improve. IMO we should provide everything except the fields added in signing (so include Fee, Sequence, and Flags but omit SigningPubKey and TxnSignature).
Also, ideally, we would add a {% tx-example txid="(hash)" /%} tag for the new transaction, with an example from Mainnet (since it'll never be reset, so any full-history server will be able to find it forever).
It might be easier to submit such a transaction yourself rather than trawl the ledger looking for one. I did write a quick script to find and display transactions of types we don't have examples of, but it hasn't found any MPTokenAuthorize examples... yet.
20c1f62 to
20225b5
Compare
Yeah couldn't find any so I've now created my own MPT issuance and an MPT holder on Mainnet. I've also updated the other MPT transactions and added the |
08fab4b to
3cf5dd1
Compare
3cf5dd1 to
f511a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
Fix #3185.